Review Request 111287: Fix of an issue in Escape Key functioning

Akshay Ratan akshay_ratan at yahoo.com
Fri Jun 28 07:51:56 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111287/
-----------------------------------------------------------

Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Description
-------

Steps to reproduce the earlier error :

1) Select the BROWSE PICTURES/MUSIC/VIDEO option from the categories in plasma-mediacenter Homescreen
2) Press Escape Key when the "PLACE screen" or initial browsing window having various drives appears. Don't select anything, just press escape intending to go    back to the homescreen.
3) Result:: PMC Application crashes 

However BACK button on the toolbar works fine.

This patch aims to solve this issue in escape key functioning. 

Shantanu: However, after applying this patch, as you will notice, escape key in the same scenario mentioned in Step 2 , would take the user back "by one level" and NOT to the homescreen. Please see if this is the behaviour required.


Diffs
-----

  browsingbackends/localfiles/localfilesabstractbackend.cpp 31ada99 

Diff: http://git.reviewboard.kde.org/r/111287/diff/


Testing
-------

Yes. Application does not crash now in the scenario mentioned :)


Thanks,

Akshay Ratan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130628/4140e16b/attachment.html>


More information about the Plasma-devel mailing list