Review Request 111263: Revamping the filesystem browser in the plasma-mediacenter

[Akshay Ratan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111263/
-----------------------------------------------------------

(Updated June 26, 2013, 7:22 p.m.)


Review request for Plasma, Fabian Riethmayer, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Changes
-------

Solved the Url problem--> Now the correct folder contents appear on clicking any folder.

One major issue which I see now is that there is no method to again see the "main places menu" which has various drives and home folder once you navigate a particular place.

Steps to reproduce::
1) Open "home" folder
2) Browse Contents, see pictures etc
3) Try going to and navigating any mounted drive  


Description
-------

The File explorer/browser in the plasma-mediacenter has been revamped. The side-panel has been removed. Now the drives and other system directories appears on clicking "Browse Pics/Music/Videos" instead of "home" folder contents appeaaring earlier after selecting this particular option. 


Diffs (updated)
-----

  browsingbackends/localfiles/localfilesabstractbackend.h b7cc909 
  browsingbackends/localfiles/localfilesabstractbackend.cpp 5768fb3 
  browsingbackends/localfiles/localfilesabstractmodel.h c4c8be3 
  browsingbackends/localfiles/localfilesabstractmodel.cpp 6c66b43 
  browsingbackends/localfiles/localmusic/CMakeLists.txt 4b804ae 
  browsingbackends/localfiles/localpictures/CMakeLists.txt c7ba5fa 
  browsingbackends/localfiles/localplacesmodel.h PRE-CREATION 
  browsingbackends/localfiles/localplacesmodel.cpp PRE-CREATION 
  browsingbackends/localfiles/localvideos/CMakeLists.txt 15677d7 

Diff: http://git.reviewboard.kde.org/r/111263/diff/


Testing
-------

Major things working fine , but there might be certain issues regarding the correct folder contents shown inside any folder in any particular directory.

Further malformed url might appear on clicking certain drives. However this can be fixed later :)


Thanks,

Akshay Ratan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130626/953b92e2/attachment.html>