Review Request 111187: Implement UI navigation using PageStack

[Sinny Kumari]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111187/#review34911
-----------------------------------------------------------


According to me, Playlist icon should toggle. If user have to click on playlist button to view playlist, user will expect that clicking once again will hide it especially in touch devices.

One more issue, related to https://bugs.kde.org/show_bug.cgi?id=318816 . Opening associated audio/video file in PMC, first homescreen appear then playlist and then video is visible. It looks little awkward.
Expected behaviour: Only video player should be visible

- Sinny Kumari


On June 23, 2013, 2:26 p.m., Shantanu Tushar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111187/
> -----------------------------------------------------------
> 
> (Updated June 23, 2013, 2:26 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Fabian Riethmayer, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Description
> -------
> 
> Using a PageStack for navigation in PMC has lots of benefits, the most important one is that it makes navigation flows easier to handle. We can remove old hacks, cleanup code that used to manage navigation.
> On the user's end, this brings more intuitive navigation from homescreen to browser, to playlist etc. Plus, keyboard navigation is much easier to do.
> 
> This patch improves the UI flows and keyboard navigation. There are still few things that don't have key bindings, so only report issues that are regressions.
> 
> 
> Diffs
> -----
> 
>   browsingbackends/localfiles/localfilesabstractbackend.cpp 4e2b336 
>   browsingbackends/localfiles/localfilesabstractmodel.cpp 158725c 
>   browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml 074d5a8 
>   browsingbackends/onlineservices/youtube/youtubebackend.desktop 648ead0 
>   mediaelements/CMakeLists.txt 4894d36 
>   mediaelements/imageviewer/ImageViewer.qml 27b93f5 
>   mediaelements/imageviewer/PictureStrip.qml 187d687 
>   mediaelements/imageviewer/PictureStripDelegate.qml 0c995bf 
>   mediaelements/keyhandler/KeyHandler.qml 0821c2c 
>   mediaelements/keyhandler/Logic.js b574221 
>   mediaelements/mediabrowser/MediaBrowser.qml 04261aa 
>   mediaelements/mediabrowser/MediaItem.qml 2d6fac5 
>   mediaelements/mediacontroller/MediaController.qml 5d62a0f 
>   mediaelements/mediaplayer/MediaPlayer.qml e6df21d 
>   mediaelements/mediawelcome/BackendsListDelegate.qml 7b9713a 
>   mediaelements/mediawelcome/MediaWelcome.qml 6c4554e 
>   mediaelements/playlist/Playlist.qml dfa6c8d 
>   mediaelements/playlist/PlaylistDelegate.qml a2b4fae 
>   mediaelements/qmldir 2d543c5 
>   mediaelements/runtimedata/RuntimeData.qml 8524b47 
>   shells/newshell/mainwindow.h 544618f 
>   shells/newshell/mainwindow.cpp 113748e 
>   shells/newshell/package/contents/ui/mediacenter.qml d533b60 
> 
> Diff: http://git.reviewboard.kde.org/r/111187/diff/
> 
> 
> Testing
> -------
> 
> Tested in my branch pagestack-shantanu, works awesome.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130623/ad5e4e07/attachment-0001.html>