Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111148/#review34881
-----------------------------------------------------------

Ship it!


For absolute completeness, the sortCaseSensitivity property should also have a NOTIFY signal .. but i don't see why anyone would ever bind to that signal and it would require a reimplementation of the set method, so i'm fine with it going in without .. so a +1 from me; if Marco can confirm then this is good to go in.

- Aaron J. Seigo


On June 22, 2013, 2:42 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111148/
> -----------------------------------------------------------
> 
> (Updated June 22, 2013, 2:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case insensitive.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/core/datamodel.h 0943b68 
>   plasma/declarativeimports/core/datamodel.cpp f81e579 
> 
> Diff: http://git.reviewboard.kde.org/r/111148/diff/
> 
> 
> Testing
> -------
> 
> Tested with the battery monitor. Now "eva" comes before "Logitech" :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130622/30b4e34e/attachment.html>