Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

Marco Martin notmart at gmail.com
Fri Jun 21 09:16:04 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111148/#review34813
-----------------------------------------------------------


the patch is almost ok, tough can you still find a way to make it emit a sortOrderChanged signal?

- Marco Martin


On June 20, 2013, 9:41 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111148/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 9:41 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case insensitive.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/core/datamodel.h 0943b68 
> 
> Diff: http://git.reviewboard.kde.org/r/111148/diff/
> 
> 
> Testing
> -------
> 
> Tested with the battery monitor. Now "eva" comes before "Logitech" :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130621/f6de43fa/attachment-0001.html>


More information about the Plasma-devel mailing list