Review Request 110716: Get the Plasma Theme Text Color for the Notes applet

Aaron J. Seigo aseigo at kde.org
Fri Jun 21 09:01:58 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110716/#review34811
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On May 29, 2013, 6:57 p.m., Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110716/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 6:57 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Davide Bettio, and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> For theme text color, the code was Plasma::Theme::ButtonTextColor instead of Plasma::Theme::TextColor in 2 places. When the theme changes, make the text change color.
> 
> 
> This addresses bug 320342.
>     http://bugs.kde.org/show_bug.cgi?id=320342
> 
> 
> Diffs
> -----
> 
>   applets/notes/notes.cpp 5c2ed70 
> 
> Diff: http://git.reviewboard.kde.org/r/110716/diff/
> 
> 
> Testing
> -------
> 
> Tested with several themes, Air, ThinAir2 and Oxygen. 
> 
> 
> Thanks,
> 
> Anne-Marie Mahfouf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130621/4902dac7/attachment.html>


More information about the Plasma-devel mailing list