Review Request 111047: Handle edge cases when going back/escape

Sinny Kumari ksinny at gmail.com
Thu Jun 20 18:53:24 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111047/#review34797
-----------------------------------------------------------

Ship it!


Still whatever I mentioned is broken.
For now, I will suggest ship diff r2 because it handle all major cases. Remaining cases we can handle when we re-write keyboard navigation stuff.

- Sinny Kumari


On June 20, 2013, 12:19 p.m., Shantanu Tushar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111047/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 12:19 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan and Sinny Kumari.
> 
> 
> Description
> -------
> 
> At places we assume that there always be a valid browsing backend. In many situations this isn't true, which is exactly what this patch handles.
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediabrowser/MediaBrowser.qml e7aa109 
>   shells/newshell/package/contents/ui/mediacenter.qml d533b60 
> 
> Diff: http://git.reviewboard.kde.org/r/111047/diff/
> 
> 
> Testing
> -------
> 
> Tested some scenarios that I could think of. Please test few scenarios and see if this works.
> Akshay: I think the new if conditions make previousBackend necessary, please check that your feature still works fine.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130620/01fdec27/attachment.html>


More information about the Plasma-devel mailing list