Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

[Marco Martin]

> On June 20, 2013, 9:20 a.m., Aaron J. Seigo wrote:
> > plasma/declarativeimports/core/datamodel.h, line 94
> > <http://git.reviewboard.kde.org/r/111148/diff/1/?file=164874#file164874line94>
> >
> >     is this necessary, given that there is a setSortCaseSensitivity in the parent class?
> 
> Marco Martin wrote:
>     you can bind qproperty read and write on superclass methods as well.
>     one reason it might be necessary is because you want also a notify signal when it changes (so property bindings can work)
>     so you can emit the signal when you set the property
>     
>     another way could be rechecking the sort property when the model gets reset, so the signal can be emitted there...

aand, i see the old property setSortorder is lacking a notify signal as well :/
it should have it too


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111148/#review34738
-----------------------------------------------------------


On June 20, 2013, 9:41 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111148/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 9:41 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case insensitive.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/core/datamodel.h 0943b68 
> 
> Diff: http://git.reviewboard.kde.org/r/111148/diff/
> 
> 
> Testing
> -------
> 
> Tested with the battery monitor. Now "eva" comes before "Logitech" :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130620/51eee482/attachment.html>