Review Request 111074: Adapt the CMakeLists to the cmake modules changes

Alexander Neundorf neundorf at kde.org
Mon Jun 17 18:16:34 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111074/#review34509
-----------------------------------------------------------

Ship it!


A better "PURPOSE" wouldn't hurt, otherwise it looks good.


- Alexander Neundorf


On June 17, 2013, 4:10 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111074/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 4:10 p.m.)
> 
> 
> Review request for Plasma and Alexander Neundorf.
> 
> 
> Description
> -------
> 
> MacroLogFeature has been removed. See ECM_SouceIncompatChanges[1]
> 
> [1] http://techbase.kde.org/Development/ECM_SourceIncompatChanges#MacroLogFeature.cmake
> 
> 
> Diffs
> -----
> 
>   src/plasma/CMakeLists.txt 0503255 
>   src/plasma/staging/CMakeLists.txt 1e11708 
> 
> Diff: http://git.reviewboard.kde.org/r/111074/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130617/a2395d76/attachment.html>


More information about the Plasma-devel mailing list