Review Request 111047: Handle edge cases when going back/escape

[Akshay Ratan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111047/#review34416
-----------------------------------------------------------


I found a small glitch, please reproduce this error. 
Steps:
1) Go to Browse Pics/Videos/Music
2) Play a media ( eg pictures will open in the slideshow)
3) Pressing Escape key once will take you one level back as intended, but again pressing escape key breaks the flow now.Nothing happens, and that is intuitively due to currentBrowsingBackend loosing track. In short, please try pressing "Escape Key" twice in the slideshow to go back to the homescreen. It wont work.

OR 

for that matter, even when you go to Browse Pics/Videos/Music, in the media browser itself, try pressing Escape Key to go back again to the homescreen, the PMC breaks in this instance.

- Akshay Ratan


On June 16, 2013, 7:36 a.m., Shantanu Tushar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111047/
> -----------------------------------------------------------
> 
> (Updated June 16, 2013, 7:36 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan and Sinny Kumari.
> 
> 
> Description
> -------
> 
> At places we assume that there always be a valid browsing backend. In many situations this isn't true, which is exactly what this patch handles.
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediabrowser/MediaBrowser.qml e7aa109 
>   shells/newshell/package/contents/ui/mediacenter.qml d533b60 
> 
> Diff: http://git.reviewboard.kde.org/r/111047/diff/
> 
> 
> Testing
> -------
> 
> Tested some scenarios that I could think of. Please test few scenarios and see if this works.
> Akshay: I think the new if conditions make previousBackend necessary, please check that your feature still works fine.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130616/5f14ad7b/attachment.html>