Review Request 111035: Merging sinny-youtube branch to master

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111035/#review34387
-----------------------------------------------------------


Awesome stuff, undoubtely one of the most useful backends ever :D
This can merge to master, just fix these small issues before merging.


browsingbackends/onlineservices/youtube/videodetailsmodel.cpp
<http://git.reviewboard.kde.org/r/111035/#comment25258>

    can you do this using initialization lists, http://stackoverflow.com/questions/4589237/c-initialization-lists



browsingbackends/onlineservices/youtube/videodetailsmodel.cpp
<http://git.reviewboard.kde.org/r/111035/#comment25259>

    when does this get deleted? Make sure you delete this when its no longer needed (use QObject::deleteLater as Video is a QObject derivative)



browsingbackends/onlineservices/youtube/videodetailsmodel.cpp
<http://git.reviewboard.kde.org/r/111035/#comment25260>

    add a const ref for the param



browsingbackends/onlineservices/youtube/youtubebackend.h
<http://git.reviewboard.kde.org/r/111035/#comment25261>

    s/Picasa/Youtube



browsingbackends/onlineservices/youtube/youtubebackend.h
<http://git.reviewboard.kde.org/r/111035/#comment25262>

    m_ ?



browsingbackends/onlineservices/youtube/youtubebackend.h
<http://git.reviewboard.kde.org/r/111035/#comment25263>

    m_expanded sounds like a better name



browsingbackends/onlineservices/youtube/youtubebackend.cpp
<http://git.reviewboard.kde.org/r/111035/#comment25264>

    else is not needed


- Shantanu Tushar


On June 15, 2013, 6:11 a.m., Sinny Kumari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111035/
> -----------------------------------------------------------
> 
> (Updated June 15, 2013, 6:11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Support of watching youtube video  has been added in branch sinny-youtube. Currently, it contains features:
> 1. Search for youtube video
> 2. Play selected video
> 3. Other basic functionalities like play, pause, seek, etc currently playing video
> 
> 
> Diffs
> -----
> 
>   browsingbackends/onlineservices/CMakeLists.txt 860e2a4 
>   browsingbackends/onlineservices/youtube/CMakeLists.txt PRE-CREATION 
>   browsingbackends/onlineservices/youtube/constants.h PRE-CREATION 
>   browsingbackends/onlineservices/youtube/diskcache.h PRE-CREATION 
>   browsingbackends/onlineservices/youtube/diskcache.cpp PRE-CREATION 
>   browsingbackends/onlineservices/youtube/global.h PRE-CREATION 
>   browsingbackends/onlineservices/youtube/networkaccess.h PRE-CREATION 
>   browsingbackends/onlineservices/youtube/networkaccess.cpp PRE-CREATION 
>   browsingbackends/onlineservices/youtube/video.h PRE-CREATION 
>   browsingbackends/onlineservices/youtube/video.cpp PRE-CREATION 
>   browsingbackends/onlineservices/youtube/videodefinition.h PRE-CREATION 
>   browsingbackends/onlineservices/youtube/videodefinition.cpp PRE-CREATION 
>   browsingbackends/onlineservices/youtube/videodetailsmodel.h PRE-CREATION 
>   browsingbackends/onlineservices/youtube/videodetailsmodel.cpp PRE-CREATION 
>   browsingbackends/onlineservices/youtube/youtubebackend.h PRE-CREATION 
>   browsingbackends/onlineservices/youtube/youtubebackend.cpp PRE-CREATION 
>   browsingbackends/onlineservices/youtube/youtubebackend.desktop PRE-CREATION 
>   browsingbackends/onlineservices/youtube/youtubemodel.h PRE-CREATION 
>   browsingbackends/onlineservices/youtube/youtubemodel.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111035/diff/
> 
> 
> Testing
> -------
> 
> Works fine
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_browser_2.png
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video_1.png
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video_play_1.png
> 
> 
> Thanks,
> 
> Sinny Kumari
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130615/a6bb4f12/attachment.html>