Review Request 111034: Merging sinny-youtube branch to master

Sinny Kumari ksinny at gmail.com
Sat Jun 15 05:04:32 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111034/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Support of watching youtube video  has be added in branch sinny-youtube. Currently, it contains features:
1. Search for youtube video
2. Play selected video
3. Other basic functionalities like play, pause, seek, etc currently playing video


Diffs
-----

  browsingbackends/onlineservices/CMakeLists.txt 860e2a4 
  browsingbackends/onlineservices/youtube/CMakeLists.txt PRE-CREATION 
  browsingbackends/onlineservices/youtube/constants.h PRE-CREATION 
  browsingbackends/onlineservices/youtube/diskcache.h PRE-CREATION 
  browsingbackends/onlineservices/youtube/diskcache.cpp PRE-CREATION 
  browsingbackends/onlineservices/youtube/global.h PRE-CREATION 
  browsingbackends/onlineservices/youtube/networkaccess.h PRE-CREATION 
  browsingbackends/onlineservices/youtube/networkaccess.cpp PRE-CREATION 
  browsingbackends/onlineservices/youtube/video.h PRE-CREATION 
  browsingbackends/onlineservices/youtube/video.cpp PRE-CREATION 
  browsingbackends/onlineservices/youtube/videodefinition.h PRE-CREATION 
  browsingbackends/onlineservices/youtube/videodefinition.cpp PRE-CREATION 
  browsingbackends/onlineservices/youtube/videodetailsmodel.h PRE-CREATION 
  browsingbackends/onlineservices/youtube/videodetailsmodel.cpp PRE-CREATION 
  browsingbackends/onlineservices/youtube/youtubebackend.h PRE-CREATION 
  browsingbackends/onlineservices/youtube/youtubebackend.cpp PRE-CREATION 
  browsingbackends/onlineservices/youtube/youtubebackend.desktop PRE-CREATION 
  browsingbackends/onlineservices/youtube/youtubemodel.h PRE-CREATION 
  browsingbackends/onlineservices/youtube/youtubemodel.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111034/diff/


Testing
-------

Works fine


File Attachments
----------------

snapshots
  http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_browser.png

  http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video.png

  http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video_play.png


Thanks,

Sinny Kumari

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130615/b29cb797/attachment.html>


More information about the Plasma-devel mailing list