Review Request 111006: Escape Key fix in the media player

[Sinny Kumari]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111006/#review34368
-----------------------------------------------------------

Ship it!


Looks good to me.
Ship it!

- Sinny Kumari


On June 13, 2013, 8:35 p.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111006/
> -----------------------------------------------------------
> 
> (Updated June 13, 2013, 8:35 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Description
> -------
> 
> Steps to reproduce the existing error-
> 
> Open a video in the Plasma Media Center.
> Navigate to main screen and click the empty screen to go back to the media
> Video again opens, now try pressing escape key to realize that there is no option to go back.
> 
> A couple of line patch to fix this ensuring Escape Key works as required in the media player.
> 
> 
> Diffs
> -----
> 
>   shells/newshell/package/contents/ui/mediacenter.qml d56344d 
> 
> Diff: http://git.reviewboard.kde.org/r/111006/diff/
> 
> 
> Testing
> -------
> 
> Works as intended.
> 
> 
> Thanks,
> 
> Akshay Ratan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130614/6e8fdd7a/attachment.html>