Review Request 110967: Icontasks: add an option to disable mouse wheel for task switching

[Aaron J. Seigo]

> On June 12, 2013, 8:49 a.m., Marco Martin wrote:
> > hm, this should be a global thing rather a config of a particular applet
> 
> Luca Manganelli wrote:
>     Right. The task-switching by scroll wheel affects the standard task bar panel, too.
>     
>     These two plasmoids (icontasks and the standard task bar panel) share the almost same wheelEvent.
> 
> Martin Gräßlin wrote:
>     it's not just tasks, it's almost everything. Good example is the digital clock or the pager. So I agree with Marco: this should be global.
>     
>     As I went through a lot of bug reports lately: many users have problems with it, so I would vote for global option disabled by default.

Yep; in fact, if you see the bug report (which is probably 3 or more years old at this point!) I said exactly this -> it needs to be a global setting and go into the workspace behaviour control panel. I have rejected other patches for exactly this reason.


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110967/#review34208
-----------------------------------------------------------


On June 12, 2013, 8:44 a.m., Luca Manganelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110967/
> -----------------------------------------------------------
> 
> (Updated June 12, 2013, 8:44 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch adds a checkbox "Disable task switching with scroll wheel" in the configuration dialog box (tab "Behaviour").
> 
> Since it adds a new string, I think that this diff will not pushed before KDE 4.11, right?
> 
> 
> This addresses bug 320523.
>     http://bugs.kde.org/show_bug.cgi?id=320523
> 
> 
> Diffs
> -----
> 
>   applets/icontasks/behaviourconfig.ui ec0a9ba 
>   applets/icontasks/taskgroupitem.h a249391 
>   applets/icontasks/taskgroupitem.cpp cdc411f 
>   applets/icontasks/tasks.cpp a293564 
> 
> Diff: http://git.reviewboard.kde.org/r/110967/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luca Manganelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130613/dd87b196/attachment.html>