Review Request 110476: Call KNotification::close() when notification is closed in the applet

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110476/#review33981
-----------------------------------------------------------



plasma/generic/dataengines/notifications/notificationaction.cpp
<http://git.reviewboard.kde.org/r/110476/#comment25016>

    This change seems unneeded.



plasma/generic/dataengines/notifications/notificationsengine.cpp
<http://git.reviewboard.kde.org/r/110476/#comment25018>

    I think "immediately" is better than "directly" here. I still do not fully understand this comment, deleting a service before it finishes sounds like a bug to me.


- Lamarque Souza


On June 9, 2013, 1:11 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110476/
> -----------------------------------------------------------
> 
> (Updated June 9, 2013, 1:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Call KNotification::close() when user clicks the 'X' button in the Notifications applet.
> 
> This prevents leaking persistent notifications and allows applications to depend on KNotification::closed() signal.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml 64d9298 
>   plasma/generic/applets/notifications/contents/ui/Notifications.qml c5be0a3 
>   plasma/generic/dataengines/notifications/notificationaction.cpp 397073e 
>   plasma/generic/dataengines/notifications/notificationsengine.cpp 25fccbb 
> 
> Diff: http://git.reviewboard.kde.org/r/110476/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130609/4a1f2854/attachment-0001.html>