Review Request 110864: Do not try to raise a Plasma::Dialog which is a dock window

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110864/#review33902
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On June 7, 2013, 12:54 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110864/
> -----------------------------------------------------------
> 
> (Updated June 7, 2013, 12:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Do not try to raise a Plasma::Dialog which is a dock window
> 
> For a dock window the raise does not make much sense. A window manager
> raises it anyway above most windows to get it into the dock layer. But
> the raise can cause quite some side effects. KWin is setting demands
> attention state in that case resulting in e.g. the notification window
> having demands attention set. This conflicts with the general demands
> attention handling like for example a chat window demanding attention and
> emitting a notification at the same time.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/core/dialog.cpp 5c948ec91aa989b2712e3cbe4baed446e1d94764 
> 
> Diff: http://git.reviewboard.kde.org/r/110864/diff/
> 
> 
> Testing
> -------
> 
> notifications are no longer demanding attention
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130607/b2fa35c2/attachment.html>