Review Request 110856: A minor fix to make the "Back button" on the Media Controller of the PMC work when the user clicks on the empty homescreen space to open up the slideshow again.

Shantanu Tushar shantanu at kde.org
Fri Jun 7 02:52:45 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110856/#review33887
-----------------------------------------------------------


backStopped should be set to true if and only if mediaBrowser.currentBrowsingBackend.goOneLevelUp() returns false. The reason is that on clicking back we tell the backend to go one level up and when it has reached the topmost level, it returns false and then only we move to the homescreen. Yes the local browsing doesnt use this anymore, but you can try with logging into picasa, going inside any album and then clicking back, it should take you back to your albums list, not homescreen.

- Shantanu Tushar


On June 6, 2013, 9:23 p.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110856/
> -----------------------------------------------------------
> 
> (Updated June 6, 2013, 9:23 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Description
> -------
> 
> A single line fix to make the "Back button" on the Media Controller of the PMC work when the user clicks on the empty homescreen space to open up the slideshow again.
> 
> Earlier there seemed to be some issue with the back button on the controller. Nothing happened on clicking it.
> 
> 
> Diffs
> -----
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 9792607 
> 
> Diff: http://git.reviewboard.kde.org/r/110856/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Akshay Ratan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130607/00f16752/attachment.html>


More information about the Plasma-devel mailing list