Review Request 110786: Use dialog svg instead of tooltip for popupview

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110786/
-----------------------------------------------------------

(Updated June 3, 2013, 3:24 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Marco Martin.


Description
-------

Patch for folderview.
Currently it works, but "only by chance" -> if dialog has a shadow prefix, and tooltip doesn't then https://bugs.kde.org/show_bug.cgi?id=320265#c2 happens (with e.g. Air, do mv tooltip.svgz panel-background.svgz, ln -s ../../widgets/background.svgz tooltip.svgz). Works if dialogs *and* tooltips *both* (don't) have shadow prefix.
Also fix compiler warning.


This addresses bug 320265.
    http://bugs.kde.org/show_bug.cgi?id=320265


Diffs
-----

  plasma/applets/folderview/popupview.h e00e5ba 
  plasma/applets/folderview/popupview.cpp 75db43e 

Diff: http://git.reviewboard.kde.org/r/110786/diff/


Testing
-------

Tested all combos, works now. I guess it's also more of a dialog really than a tooltip, no?


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130603/a95e0a93/attachment.html>