Review Request 110761: Fix behaviour in DialogProxy::setAttribute

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110761/
-----------------------------------------------------------

(Updated June 3, 2013, 10:02 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Description
-------

Fix behaviour in DialogProxy::setAttribute 

Only call KWindowSystem::setOnAllDesktops when we enable WindowTypeDock
and only remove KWindowSystem::setOnAllDesktops when we disable WindowTypeDock
not when we set any other attribute (which is what previous code does)

---

Old code looked wrong, I was hunting down a different bug when I noticed it.

In reality despite being "wrong", it doesn't seem to have caused any problems so far as the only usage seems to be the notification plasmoid which simply calls setAttribute(Qt.WA_X11NetWmWindowTypeDock, true) once. 


Diffs
-----

  plasma/declarativeimports/core/dialog.cpp b19ff5b8c576d18646f4d62c8ee35ca91f1dd17d 

Diff: http://git.reviewboard.kde.org/r/110761/diff/


Testing
-------

Notification plasmoid behaved exactly the same as before.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130603/edea097f/attachment.html>