Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

[Akshay Ratan]

> On June 2, 2013, 1:53 p.m., Sinny Kumari wrote:
> > shells/newshell/package/contents/ui/mediacenter.qml, line 227
> > <http://git.reviewboard.kde.org/r/110776/diff/5/?file=147683#file147683line227>
> >
> >     Instead of checking
> >     if(mediaImageViewer.visible || mediaPlayer.hasVideo), check for if((mediaImageViewer.source != "") || (mediaPlayer.url != "")
> >     
> >     It will handle Music mode too

Thanks for the advice :)


- Akshay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110776/#review33583
-----------------------------------------------------------


On June 2, 2013, 4:50 p.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110776/
> -----------------------------------------------------------
> 
> (Updated June 2, 2013, 4:50 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Description
> -------
> 
> Clicking on the Empty top and bottom spaces of the Plasma Media Center's Homescreen takes the user back to the media being played--Video or Slideshow.
> 
> When user is viewing the pictures and comes on the main screen of the PMC, now when he/she clicks the empty welcome screen , directly slideshow appears as intended.
> 
> Same is the case with videos.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=317451.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=317451
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediabrowser/MediaBrowser.qml d978285 
>   mediaelements/mediawelcome/MediaWelcome.qml c524582 
>   shells/newshell/package/contents/ui/mediacenter.qml b4a659a 
> 
> Diff: http://git.reviewboard.kde.org/r/110776/diff/
> 
> 
> Testing
> -------
> 
> Yes, works as intended.
> 
> Please check for the Escape key navigation to see if it does not break the keyboard navigation flow somewhere.
> 
> 
> Thanks,
> 
> Akshay Ratan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130602/68b0b829/attachment.html>