Review Request 111770: Implemented search feature in Local Browsing.

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111770/#review36728
-----------------------------------------------------------

Ship it!


Ship It!


browsingbackends/localfiles/localfilesabstractbackend.cpp
<http://git.reviewboard.kde.org/r/111770/#comment27122>

    move this inside the if block, its a good practice to create objects only when you need them



browsingbackends/localfiles/localfilesabstractbackend.cpp
<http://git.reviewboard.kde.org/r/111770/#comment27123>

    remove trailing whitespace. (also, set kate's "remove trailing spaces" option to on).
    There are few extra whitespaces elsewhere as well, remove those as well.



browsingbackends/localfiles/localfilesabstractmodel.cpp
<http://git.reviewboard.kde.org/r/111770/#comment27124>

    If this variable is unused, remove it



browsingbackends/localfiles/localfilesabstractmodel.cpp
<http://git.reviewboard.kde.org/r/111770/#comment27125>

    Here as well


- Shantanu Tushar


On July 28, 2013, 8:08 p.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111770/
> -----------------------------------------------------------
> 
> (Updated July 28, 2013, 8:08 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Description
> -------
> 
> Plasma Media Center now supports searching in local files and media. Used Regular expression to match the name.
> 
> 
> Diffs
> -----
> 
>   browsingbackends/localfiles/localfilesabstractbackend.h 84758e4 
>   browsingbackends/localfiles/localfilesabstractbackend.cpp 1144e49 
>   browsingbackends/localfiles/localfilesabstractmodel.h 43f50b7 
>   browsingbackends/localfiles/localfilesabstractmodel.cpp ebfc602 
> 
> Diff: http://git.reviewboard.kde.org/r/111770/diff/
> 
> 
> Testing
> -------
> 
> Works as intended.
> 
> 
> Thanks,
> 
> Akshay Ratan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130729/d52ff2f1/attachment.html>