Review Request 111650: Adjust RunnerManager to new ThreadWeaver API using JobPointer
Martin Gräßlin
mgraesslin at kde.org
Tue Jul 23 08:12:16 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111650/
-----------------------------------------------------------
Review request for KDE Frameworks and Plasma.
Description
-------
ThreadWeaver does not use Job* anymore which made the code compile fail and some connects being wrong.
This patch adjusts RunnerManager to also use QSharedPointer<FindMatchJob> instead of FindMatchJob*. It
simplifies a few things as we do no longer have to call e.g. qDeleteAll and fixes the incorrect connects.
The patch also enables C++11 as it uses auto.
Diffs
-----
CMakeLists.txt d4d0a43
src/plasma/private/runnerjobs.cpp a012a6c
src/plasma/private/runnerjobs_p.h cf05324
src/plasma/runnermanager.h ebeb029
src/plasma/runnermanager.cpp 46857f4
Diff: http://git.reviewboard.kde.org/r/111650/diff/
Testing
-------
compiles, but couldn't run the unit tests (something is broken in my setup)
Thanks,
Martin Gräßlin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130723/571758ef/attachment-0001.html>
More information about the Plasma-devel
mailing list