Review Request 111621: Increase size of label pixmap to account for margins and shadows

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111621/#review36232
-----------------------------------------------------------

Ship it!


Looks good in practice, thanks.

- Eike Hein


On July 20, 2013, 4:53 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111621/
> -----------------------------------------------------------
> 
> (Updated July 20, 2013, 4:53 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Description
> -------
> 
> The text label is rendered into a pixmap which can be smaller than the actual text, because the item rect is inside some margins.
> 
> This patch does two things:
> - increase the pixmap size by 4 pixels on top and bottom
> - fix the text positioning
> 
> 
> This addresses bug 314879.
>     http://bugs.kde.org/show_bug.cgi?id=314879
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/tasks/support/textlabel.cpp 9fbc12d 
> 
> Diff: http://git.reviewboard.kde.org/r/111621/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130721/326d8c95/attachment-0001.html>