Review Request 111553: Fix for the Revision 2f4ab1e6 and Subtitle feature extension in PMC to .sub file format as well.

[Akshay Ratan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111553/
-----------------------------------------------------------

Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.


Description
-------

This patch essentially aims at extending the subtitle feature to .sub file format also.

Also, this serves as a fix after the Revision 2f4ab1e6 (https://projects.kde.org/projects/extragear/multimedia/plasma-mediacenter/repository/revisions/2f4ab1e61149bd9b9487d985845ebdc1b8ec41bb/diff/libs/mediacenter/subtitleprovider.cpp) breaks the existing .srt subtitle support as well.

Steps to test:
1) Play a movie or any video file which has a .sub or .txt or .srt format subtitle.
2) Subtitles should come as the video play ( Ofcourse only is the subtitle file name is same as that of movie file name)


Diffs
-----

  libs/mediacenter/subtitleprovider.h 8647ded 
  libs/mediacenter/subtitleprovider.cpp 32094b0 
  mediaelements/mediaplayer/MediaPlayer.qml 2567312 

Diff: http://git.reviewboard.kde.org/r/111553/diff/


Testing
-------

Shantanu : I guess the subtitle patch which got committed in the master in that revision was by mistake. That broke the existing subtitle support for .srt as well. Applying this one over it solves the issue :)

However, please test it once as still on my system , when a .sub subtitle should play , following is the debug console error output :: 

(plasma-mediacenter:12999): GStreamer-CRITICAL **: gst_pad_link_full: assertion `GST_IS_PAD (sinkpad)' failed


.srt subtitle plays fine :)
 


Thanks,

Akshay Ratan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130717/a744c7fe/attachment.html>