Review Request 111367: fix rich text in new notification popup

Aaron J. Seigo aseigo at kde.org
Wed Jul 3 09:18:58 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111367/#review35495
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On July 2, 2013, 4:08 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111367/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 4:08 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> some symbol like > from ktp cannot be displayed in new popup, but can be displayed correctly in notification history.
> 
> PlasmaComponent.Label in LastNotificationPopup doesn't use rich text, while TextEdit in NotificationDelegate use rich text.
> 
> This patch make LastNotificationPopup also use RichText and looks it fix the problem.
> 
> Incorrect screenshot: http://susepaste.org/3367166
> Correct screenshot: http://susepaste.org/28278632
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 0e16e40 
> 
> Diff: http://git.reviewboard.kde.org/r/111367/diff/
> 
> 
> Testing
> -------
> 
> send >> from ktp and check notification, all displayed as >>, send > from ktp, > is also correctly displayed.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130703/19ff0f19/attachment.html>


More information about the Plasma-devel mailing list