Review Request 111337: Enhancements and optimization in navigation flow of Plasma Media Center

[Akshay Ratan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111337/
-----------------------------------------------------------

(Updated July 1, 2013, 6:03 p.m.)


Review request for Plasma, Shantanu Tushar, Sinny Kumari, Sujith Haridasan, and Thomas Pfeiffer.


Changes
-------

Changed the stack code implementation a little bit as suggested by Shantanu.

Earlier issue mentioned in the TESTING ::  Solved :)

Please check for the application crashes if any.


Description
-------

This patch aims to enhance the file-browsing capability and navigation in the plasma-mediacenter. Implemented a stack to store the browsing URLs and thus ensure that the user can select another drive by coming to the PLACE MODEL screen on pressing escape/back required number of times. Further, earlier on clicking BROWSE Pics/Music/Videos , PMC took us to the last browsing folder but now we get back to the PLACE MODEL screen on clicking it which is more convenient for the user as he/she has all the options again to browse whatever drive they want to.


Diffs (updated)
-----

  browsingbackends/localfiles/localfilesabstractbackend.cpp 33ea4ef 
  browsingbackends/localfiles/localfilesabstractmodel.h 43f50b7 
  browsingbackends/localfiles/localfilesabstractmodel.cpp a02e65d 

Diff: http://git.reviewboard.kde.org/r/111337/diff/


Testing
-------

Yes, works as intended.

However there seems to be one small glitch::
Steps to reproduce---
1) Select a drive from PLACES MODEL screen eg FOO
2) Select a folder eg BAR
3) Select a folder inside again eg BAR2 . Now press escape/back, you will successfully go one level back to BAR.
4) Now try pressing ESCAPE/BACK, ideally PLACES MODEL Screen should be shown , but you will notice, you have to press 2 escape/back keys to go there.

Rest all works as intended and NO application crashes were experienced.


Thanks,

Akshay Ratan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130701/26717e2a/attachment.html>