Review Request 108679: Plasmate: Make konsolepreview to work even if the plasmatepreviewerlog.txt doesn't exist.

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108679/#review26447
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Kügler


On Jan. 30, 2013, 9:29 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108679/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2013, 9:29 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> KStandarDirs::locate returns a path only if the file exists, the first time that we run plasmate the plasmatepreviewerlog.txt doesn't exist so the konsolepreviewer doesn't work. In order to fix this
> we are replacing the KStandarDirs:locate with KStandarDirs::locateLocal. KStandarDirs::locateLocal always returns a path. Even if the file doesn't exist.
> 
> 
> Diffs
> -----
> 
>   plasmate/konsole/konsolepreviewer.cpp 36dcc6b 
>   plasmate/mainwindow.cpp 28f7a0e 
> 
> Diff: http://git.reviewboard.kde.org/r/108679/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130130/5fb268b6/attachment.html>