Review Request 108425: Fixes for grace time in screenlocker

[Oliver Henshaw]

> On Jan. 15, 2013, 4:47 p.m., Marco Martin wrote:
> > if a password isn't required, shouldn't hide the password dialog as well? (like showing only the background)

Good point. Maybe the dialog shouldn't be shown immediately on lock either? I've tried playing with hiding the dialog to extend https://git.reviewboard.kde.org/r/108375/ to all lockers but I keep running into stupid problems. I'll keep playing with this, though - then adding situations where the dialog is hidden becomes easier.


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108425/#review25591
-----------------------------------------------------------


On Jan. 15, 2013, 3:30 p.m., Oliver Henshaw wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108425/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2013, 3:30 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Series consists of 3 commits:
> 
> * Refactor grace time tracking
> 
> Set a boolean instead of checking whether timer is active. This is
> required for the following commits.
> 
> * Stop grace period on unlock
> 
> It was safe to leak the grace timer when it was in the lock process,
> since it was killed on unlock. Now it is not.
> 
> A password should always be required if the screenlocker is explicitly
> triggered; but a screenlocker invoked while the grace timer from a
> previous invocation is still active can be dismissed without a password,
> at least for a short while. This also meant that the screenlocker
> keyboard shortcut would not work until the grace timer expired.
> 
> * Respect Lock boolean in configuration
> 
> If not set to require password, don't start the grace period timer and
> always consider in grace period.
> 
> 
> This addresses bug 310871.
>     http://bugs.kde.org/show_bug.cgi?id=310871
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/ksldapp.h 51c0906fc6e54787af749872615770bd6005b4fb 
>   ksmserver/screenlocker/ksldapp.cpp c07ac0ef1c6643415b8c13ba438628a1e118fb72 
> 
> Diff: http://git.reviewboard.kde.org/r/108425/diff/
> 
> 
> Testing
> -------
> 
> Tested with and without password required, tested with grace time set to zero in config file. Tested idle activation, user-requested activation and behaviour after return from idle activation.
> 
> 
> Thanks,
> 
> Oliver Henshaw
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130129/d75fb15d/attachment.html>