Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

[Aaron J. Seigo]

> On Jan. 28, 2013, 11:47 a.m., Aaron J. Seigo wrote:
> > this still does not work p[roperly. now i'm getting a (too small) black rectangle on the screen around which i can see the rest of my desktop and the locker window is still not being shown. investigating now.
> 
> Thomas Lübking wrote:
>     See above, try setting "p.setColor(backgroundRole(), Qt::black);"
>     The paintEvent is worthless (right after init) - if the window is for some reason considered ARGB, it will be translucent with the formerly black painted area.
> 
> Aaron J. Seigo wrote:
>     ok, this does work better. now i get a fully black screen .. but also i get a fully black screen ;) the greeter window is stilling getting the input, so evidently has focus, but it isn't raised. i'll see what can be done about that next.
> 
> Aaron J. Seigo wrote:
>     well, THAT was easy. simply calling raise() on the view in greeterapp.cpp fixed all that.
>     
>     i also took the opportunity to get rid of kephal .. i'll post a review request momentarily.

ok, check out https://git.reviewboard.kde.org/r/108643/ ... it does indeed work as expected w/out PaintOutsidePaintEvent, but with the correct backgroundRole as thomas noted, and with an extra call to raise() the QML UI (otherwise it just gets a black screen).


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108585/#review26301
-----------------------------------------------------------


On Jan. 25, 2013, 11:04 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108585/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2013, 11:04 p.m.)
> 
> 
> Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> Actually  was wrong, we do get the signals from QDesktopWidget - so the fix is pretty trivial ;-)
> 
> Reg. bug #313835 i assume you're using some plasma screenlocker with widgets on it (which has a translucent background when compositing is active and relies on the lockwindow to cover the screen)
> 
> I've not checked such screen"saver" and have to admit, i'd not even know where to check for the sources.
> 
> 
> This addresses bug 313835.
>     http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/lockwindow.h 5cbc769 
>   ksmserver/screenlocker/lockwindow.cpp 147853b 
> 
> Diff: http://git.reviewboard.kde.org/r/108585/diff/
> 
> 
> Testing
> -------
> 
> recompiled _all_ ksmserver, logged out, in, locked the screen, updated the screen geometry ("arrrgghhh... geeezzz... goddamnfuckinghdmiinthedark"), killed the gretter (noticed that i could have simply xrandr'd the geometry from VT1 as well - "blast!")
> 
> everything is nicely black (with compositing)
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130128/55c9db3e/attachment.html>