Review Request 108641: Refactor of the Signing Code in Microbloggin Plugin

Aaron J. Seigo aseigo at kde.org
Mon Jan 28 13:05:00 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108641/#review26305
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On Jan. 28, 2013, 12:43 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108641/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2013, 12:43 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> I think this is all equivalent to the previous code, but wanted to make sure this won't break anything.
> 
> 
> Diffs
> -----
> 
>   dataengines/microblog/tweetjob.cpp ba8104a 
> 
> Diff: http://git.reviewboard.kde.org/r/108641/diff/
> 
> 
> Testing
> -------
> 
> Tested if I was still able to dent with the new code.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130128/740ff5c5/attachment-0001.html>


More information about the Plasma-devel mailing list