Review Request 108640: Check for Valid Wallet Pointer

David Narváez david.narvaez at computer.org
Mon Jan 28 12:40:31 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108640/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Related to bug 312137. According to the documentation, the wallet pointer can be null if it was denied, so we need to check for null values before the other checks.


Diffs
-----

  dataengines/microblog/koauth.cpp 7566b95 

Diff: http://git.reviewboard.kde.org/r/108640/diff/


Testing
-------

1. Make sure your plasma desktop does not have "Allow Always" in your kwallet
2. Add a microblogging plasmoid
3. Configure your plasmoid with an identi.ca account
4. Deny any kwallet prompt

Before this path it would crash trying to store the access tokens.


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130128/b41ca4c3/attachment.html>


More information about the Plasma-devel mailing list