Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

[Thomas Lübking]

> On Jan. 26, 2013, 2:03 p.m., Oliver Henshaw wrote:
> > I don't have multiple monitors to test with, but can you test with the the LockWindow set to some colour other than black? Just so that any bizarre side effects are more obvious.

What "bizarre side effects" would you expect?
My screens are ok ;-P

(I could see the clock from the WM on where the exposed area would have been and that area was now black)

I'll try by a nice dodgerblue nevertheless.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108585/#review26205
-----------------------------------------------------------


On Jan. 25, 2013, 11:04 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108585/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2013, 11:04 p.m.)
> 
> 
> Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> Actually  was wrong, we do get the signals from QDesktopWidget - so the fix is pretty trivial ;-)
> 
> Reg. bug #313835 i assume you're using some plasma screenlocker with widgets on it (which has a translucent background when compositing is active and relies on the lockwindow to cover the screen)
> 
> I've not checked such screen"saver" and have to admit, i'd not even know where to check for the sources.
> 
> 
> This addresses bug 313835.
>     http://bugs.kde.org/show_bug.cgi?id=313835
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/lockwindow.h 5cbc769 
>   ksmserver/screenlocker/lockwindow.cpp 147853b 
> 
> Diff: http://git.reviewboard.kde.org/r/108585/diff/
> 
> 
> Testing
> -------
> 
> recompiled _all_ ksmserver, logged out, in, locked the screen, updated the screen geometry ("arrrgghhh... geeezzz... goddamnfuckinghdmiinthedark"), killed the gretter (noticed that i could have simply xrandr'd the geometry from VT1 as well - "blast!")
> 
> everything is nicely black (with compositing)
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130126/c270e3bd/attachment.html>