Review Request 108585: Fix screenlocker lockwindow geometry on screen resizes

Thomas Lübking thomas.luebking at gmail.com
Fri Jan 25 23:04:30 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108585/
-----------------------------------------------------------

Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.


Description
-------

Actually  was wrong, we do get the signals from QDesktopWidget - so the fix is pretty trivial ;-)

Reg. bug #313835 i assume you're using some plasma screenlocker with widgets on it (which has a translucent background when compositing is active and relies on the lockwindow to cover the screen)

I've not checked such screen"saver" and have to admit, i'd not even know where to check for the sources.


This addresses bug 313835.
    http://bugs.kde.org/show_bug.cgi?id=313835


Diffs
-----

  ksmserver/screenlocker/lockwindow.h 5cbc769 
  ksmserver/screenlocker/lockwindow.cpp 147853b 

Diff: http://git.reviewboard.kde.org/r/108585/diff/


Testing
-------

recompiled _all_ ksmserver, logged out, in, locked the screen, updated the screen geometry ("arrrgghhh... geeezzz... goddamnfuckinghdmiinthedark"), killed the gretter (noticed that i could have simply xrandr'd the geometry from VT1 as well - "blast!")

everything is nicely black (with compositing)


Thanks,

Thomas Lübking

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130125/95b29561/attachment.html>


More information about the Plasma-devel mailing list