Review Request 108534: some string in javascript is not extracted

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108534/#review26074
-----------------------------------------------------------

Ship it!


yes, this is fine. untranslated strings are always allowed to be added as translate for exactly the reason you noted: they don't break anything, but give translations teams a chance to actually, well, translate these strings :)

- Aaron J. Seigo


On Jan. 21, 2013, 10:35 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108534/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2013, 10:35 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> simple and trivial.
> 
> add -name *.js to Messages.sh
> 
> I hope this doesn't break the rule of string freeze.. those will still remain untranslated if patch is not applied, and from existing po file, those string was already being translated, though currently comment out by Scripty update.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/batterymonitor/Messages.sh a40d256 
>   plasma/generic/applets/lock_logout/Messages.sh 67892db 
> 
> Diff: http://git.reviewboard.kde.org/r/108534/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130123/add9c410/attachment.html>