Review Request 108465: a couple of fixes in participant/changeAccountDetails

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108465/#review25888
-----------------------------------------------------------

Ship it!


other than the one next() that should remain, this looks fine. put that next() back in and then push it.


server/lib/db/changeAccountDetails.js
<http://git.reviewboard.kde.org/r/108465/#comment19795>

    should remain just so that if something does get added to it later, we don't have to track down where it isn't getting next() from


- Aaron J. Seigo


On Jan. 18, 2013, 7:38 a.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108465/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2013, 7:38 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This does does 2 things:
> 
> 1. adds a next() in order sometime to reach completeUpdate(), right now it doesn't
> 2. removes next() from completeUpdate(), completeUpdate is tha last method we don't have
> others, so we don't need this next()
> 
> 
> Diffs
> -----
> 
>   server/lib/db/changeAccountDetails.js fb5711b 
> 
> Diff: http://git.reviewboard.kde.org/r/108465/diff/
> 
> 
> Testing
> -------
> 
> i haven't noticed something wrong
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130121/f337fc74/attachment.html>