Review Request 108480: Always confirm "Leave..." from desktop context menu

[Jacob Welsh]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108480/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Description from bug:

There's a logout option in the desktop context menu named "Leave...". The presence of ellipses indicates to the user that there will be a confirmation dialog. However, if you've disabled "Confirm logout" in System Settings / Startup and Shutdown / Session Management, no such confirmation will be given. This breaks UI expectations and could lead to loss of unsaved work. (I still prefer to disable confirmation for the case of the kickoff menu items, which don't have ellipses and are harder to hit "by accident".)


This addresses bug 313480.
    http://bugs.kde.org/show_bug.cgi?id=313480


Diffs
-----

  plasma/generic/containmentactions/contextmenu/menu.cpp bfd60a1 

Diff: http://git.reviewboard.kde.org/r/108480/diff/


Testing
-------

None. Sorry, I gave up on getting all the KDE components built from git for the time being; was getting one error after another. If there's a quick way to test just the plasma workspace I'd be happy to try.


Thanks,

Jacob Welsh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130119/eade1010/attachment-0001.html>