Review Request 108375: fix bug 311116 / screenlocker hiding

[Thomas Lübking]

> On Jan. 16, 2013, 9:10 p.m., Oliver Henshaw wrote:
> > ksmserver/screenlocker/greeter/greeterapp.cpp, line 131
> > <http://git.reviewboard.kde.org/r/108375/diff/2/?file=107023#file107023line131>
> >
> >     It seems the DESIGN document is still correct and lockwindow.cpp should be hiding the desktop from prying eyes. So something like this may need to be done there, too. After all, what happens if the legacy screensaver crashes?

There's indeed a lockwindow - you'll get it either after the greeter crashed (kill -11; it will be restarted) or when you hide the greeter.

The LockWindow does NOT adjust to screen resizes.

Reg. the other patch, the greeter performs all relevant input processing and if that's not possible because the greeter is hidden, there's not way to show it back. The greeter cannot be hidden (and it makes little sense anyway - either there's a fancy show or the screen is off or nobody is looking anyway)

I'm dropping the issue since it's not an issue with this patch.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108375/#review25695
-----------------------------------------------------------


On Jan. 13, 2013, 9:32 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108375/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2013, 9:32 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> Ok. Redirecting to plasma.
> 
> The patch fixes:
> 
> a) setting the properties
> ... to happen on show, this is required because the "hide()" will (usually and in this case) destroy the drawable ("window") and with it all properties on the server; so they need to be re/set "when required".
> 
> b) input processing
> Relevant events are sucked so that we don't receive them more than once (usually i'd discourage from installing an eventfilter on the application but the screenlocker is ideally of low event occurrance anyway)
> 
> c) triggering events
> Not really a fix but the "saver" is now hidden on any keyPress and only reshown on escape keyRelease (iirc this was the behavior of most screenSavers when i used them because there was no dpms ...)
> 
> d) screen geometry adaptation
> if the user attaches a screen and that auto-extends the desktop, the screenlocker currently yells a warning and happily exposes the desktop (there's still a problem in case KWin fades in the locker but that's not matter to this patch)
> 
> 
> This addresses bug 311116.
>     http://bugs.kde.org/show_bug.cgi?id=311116
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/greeter.cpp f5918f9 
>   ksmserver/screenlocker/greeter/greeterapp.h 6b2c263 
>   ksmserver/screenlocker/greeter/greeterapp.cpp a35c8ae 
>   ksmserver/screenlocker/greeter/screensaverwindow.cpp adb2587 
> 
> Diff: http://git.reviewboard.kde.org/r/108375/diff/
> 
> 
> Testing
> -------
> 
> "Screensaver" - Emulation ;-)
> 
> m_showScreenSaver = true;
> // screensaverWindow->setBackground(backgroundPix);
> screensaverWindow->setAutoFillBackground(true);
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130116/5e069fbf/attachment.html>