Review Request 108441: prevent false positive mouse deactivation of screensaver

Thomas Lübking thomas.luebking at gmail.com
Wed Jan 16 16:08:35 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108441/
-----------------------------------------------------------

Review request for Plasma, Marco Martin and Oliver Henshaw.


Description
-------

The mouse movement is not correctly accounted.
Showing the window will cause an immediate moveEvent being "too big", so the measure point is set to a second invalid position to hint that this comes from a show.

As a minor change the pointless check right after setting the cursor pos to the current is omitted.


This addresses bugs (CC) and 311116.
    http://bugs.kde.org/show_bug.cgi?id=(CC)
    http://bugs.kde.org/show_bug.cgi?id=311116


Diffs
-----

  ksmserver/screenlocker/greeter/screensaverwindow.cpp 10ae31e 

Diff: http://git.reviewboard.kde.org/r/108441/diff/


Testing
-------

Yes, also no dangerous asserts included (turned out i've debug compiling only fake enabled for kwin ;-)


Thanks,

Thomas Lübking

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130116/38147956/attachment.html>


More information about the Plasma-devel mailing list