Review Request 107983: Fix KWindowSystem::compositingChanged signal

[Thomas Lübking]

> On Jan. 12, 2013, 5:25 p.m., Xuetian Weng wrote:
> > After several days test, so far no problem here.

Ok, everyone.

Thu 17. Jan 00:59:00 CET 2013     :  KDE SC 4.10 Tagging Freeze for Release Candidate 3

If we want such workaround in 4.10 I suggest to push it before that date, i'll not push it after.
Since it's not clear whether a fix can be in Qt 4.8.5 at all or when that will be released and whether distros will have it with KDE 4.10 I propose to have the workaround now, seek to get a fix into Qt and as soon as the fix is there, qVersion() the workaoround away.

I will however *not* push into kdelibs w/o any comment of some profiled kdelibs developer in this regard.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107983/#review25307
-----------------------------------------------------------


On Jan. 9, 2013, 2 a.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107983/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2013, 2 a.m.)
> 
> 
> Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Fredrik Höglund, Martin Gräßlin, and Marco Martin.
> 
> 
> Description
> -------
> 
> It works fine here (tested so far KWindowSystem signal, KSelectionWatcher only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" and e17.
> Didn't try xfce nor mutter.
> 
> Technically:
> I do not at all understand why KWindowSystem is *not* watching the root window - KSelectionOwner for one is sending events to the root and this also seems the case for all other WMs (at least everything now starts to cause the signal to be emitted)
> 
> The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner testcase), there'll be some X11 event processing on top that eats away the client messages.
> So this one can be scratched from the patch, the KWindowSystem issue remains.
> 
> 
> This addresses bug 179042.
>     http://bugs.kde.org/show_bug.cgi?id=179042
> 
> 
> Diffs
> -----
> 
>   kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 
> 
> Diff: http://git.reviewboard.kde.org/r/107983/diff/
> 
> 
> Testing
> -------
> 
> see summary
> 
> 
> File Attachments
> ----------------
> 
> testcase
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130115/078e8367/attachment-0001.html>