Review Request 108423: Call Applet::configChanged() in Containment::configChanged()

Commit Hook null at kde.org
Tue Jan 15 16:25:49 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108423/#review25589
-----------------------------------------------------------


This review has been submitted with commit 324e48c8a3f484b9b70fd33999c05f94498a0ffa by Aurélien Gâteau to branch KDE/4.10.

- Commit Hook


On Jan. 15, 2013, 12:04 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108423/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2013, 12:04 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> This patch is the second half of https://git.reviewboard.kde.org/r/108422/ . It ensures the "configChanged" event is emitted when the user changes the configuration of a QML-based containment.
> 
> 
> Diffs
> -----
> 
>   plasma/containment.cpp a454d04 
> 
> Diff: http://git.reviewboard.kde.org/r/108423/diff/
> 
> 
> Testing
> -------
> 
> Tested with the text-shadows branch of kde:homerun, settings are correctly applied when the "Apply" button is clicked.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130115/0ff87e2a/attachment.html>


More information about the Plasma-devel mailing list