Review Request 108377: fix rest von 313020

Aaron J. Seigo aseigo at kde.org
Sun Jan 13 19:26:02 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108377/#review25398
-----------------------------------------------------------

Ship it!


i actually tried this out from your patch on the bug report, and yes, it works nicely and is a big improvement over white as you noted. pls commit :)

- Aaron J. Seigo


On Jan. 13, 2013, 11:25 a.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108377/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2013, 11:25 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> As well redirecting to plasma group
> 
> The patch puts a darkish rect below the theme wallper in the QML greeter.
> Reason is that several (all but current air?) plasma themes don't provide such wallpaper and "white" is a pretty nasty background if you just came from a turned off, ie. black screen.
> 
> 
> This addresses bug 313020.
>     http://bugs.kde.org/show_bug.cgi?id=313020
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/main.qml 0e78fdd 
> 
> Diff: http://git.reviewboard.kde.org/r/108377/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130113/12cc5080/attachment-0001.html>


More information about the Plasma-devel mailing list