Review Request 108395: Fix Output::Rotation enumeration to match xrandr values

Jeremy Paul Whiting jpwhiting at kde.org
Sun Jan 13 18:40:31 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108395/
-----------------------------------------------------------

Review request for Plasma, Àlex Fiestas and Dan Vrátil.


Description
-------

Once I got my orientation data engine using libkscreen to rotate the X screen I found it was rotating the opposite of what I told it.  If I executed setRotation(KScreen::Output::Left) xrandr showed it was rotated to the right and vice versa.  It turned out the Rotation enumeration values were opposite of those expected by xrandr.  This patch fixes that.


Diffs
-----

  src/output.h 117ea79584075cb5a365f94d6c634f145e30998c 

Diff: http://git.reviewboard.kde.org/r/108395/diff/


Testing
-------

It works much better now.


Thanks,

Jeremy Paul Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130113/b601d60b/attachment.html>


More information about the Plasma-devel mailing list