Review Request 108316: Show album art in krunner results.

[Emil Sedgh]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108316/
-----------------------------------------------------------

(Updated Jan. 12, 2013, 3:46 p.m.)


Review request for Plasma.


Changes
-------

Use Christoph Feck's ImageIconEngine.


Description
-------

Audio player controller has the ability to search through Amarok's collection.
This patch uses 'arturl' property of Amarok's reply to show album art in KRunner results.

Some considerations:
arturl sent by Amarok has file:// prefix which QIcon does not understand. I used QString::remove(0,7) to remove the prefix but it seems hackish. Are there better ways of fixing this issue?
I get many warnings when I run krunner: "QPixmap: It is not safe to use pixmaps outside the GUI thread". How should I fix it?


Diffs (updated)
-----

  runners/audioplayercontrol/CMakeLists.txt 665add6 
  runners/audioplayercontrol/audioplayercontrolrunner.cpp 75afb75 

Diff: http://git.reviewboard.kde.org/r/108316/diff/


Testing
-------

Works fine if there's some album art.
Reverts to audio-x-generic icon if no arturl is defined.


Screenshots
-----------


  http://git.reviewboard.kde.org/r/108316/s/1013/


Thanks,

Emil Sedgh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130112/cf7ef331/attachment-0001.html>