Review Request: various fix for battery plasmoid

Xuetian Weng wengxt at gmail.com
Fri Jan 11 23:37:15 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108355/
-----------------------------------------------------------

Review request for Plasma, Aaron J. Seigo, Viranch Mehta, and Viranch Mehta.


Description
-------

1. fix access undefined value warning, when calling function in logic.js, pmSource.data can still be null since it might not connect at that time.
2. when brightness is passively changed from outer environment, don't trigger the dataSource service call with a bool protector called disableBrightnessUpdate, this fix bug 302130
3. move more code to DataModel.onDataChanged, under the same idea with: https://git.reviewboard.kde.org/r/108280/ , hence the plasmoid.status will always be the correct value, the changing of plasmoid.status cause bug 311491
4. remove ugly hack of resetBatteryData in logic.js.
5. fix some anchor related warning in PopupDialog.qml
QML Column: Cannot anchor to an item that isn't a parent or sibling.


This addresses bugs 302130 and 311491.
    http://bugs.kde.org/show_bug.cgi?id=302130
    http://bugs.kde.org/show_bug.cgi?id=311491


Diffs
-----

  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 5bd21a1 
  plasma/generic/applets/batterymonitor/contents/code/logic.js 7843245 
  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml eebe4fe 

Diff: http://git.reviewboard.kde.org/r/108355/diff/


Testing
-------

tested, no problem.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130111/ee1f041b/attachment.html>


More information about the Plasma-devel mailing list