Review Request: LastNotificationPopup fix for closing not to move + add move button + better layout for 3 action buttons
Leszek Lesner
leszek.lesner at web.de
Thu Jan 10 15:18:28 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108325/
-----------------------------------------------------------
Review request for Plasma and Marco Martin.
Description
-------
Fixes the LastNotificationsPopup moving around when clicking on a button and adds a move button to freely place it all over the desktop.
Also this removes notifications jobs from the notification icon. (So clicking on X does not hide but really closes the notification and removes it)
Also this fixes layout problems with 3 buttons displayed inside a notification (this caused the X button to overlap with the upper actionbutton).
As my original diff was not recognized as normal diff(don't know what I did wrong there) I attached the patch directly to this thread.
This addresses bug 311413.
http://bugs.kde.org/show_bug.cgi?id=311413
Diffs
-----
Diff: http://git.reviewboard.kde.org/r/108325/diff/
Testing
-------
kdialog --passivepopup "bla"
click on X, closes and removes job from notification Icon
click and hold on move button moves the popup freely on the screen.
Thanks,
Leszek Lesner
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130110/43ed6729/attachment.html>
More information about the Plasma-devel
mailing list