Review Request: plasmoidviewer: respect --containment flag in sizing and scenerect

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108284/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

    plasmoidviewer: respect --containment flag in sizing and scenerect
    
    The normal behavior of plasmoidviewer, which resizes the applet to the
    window, is not very useful for testing containments, at it sets the
    scenerect and resizes the widget where it is really the containment's
    job to take care of the layout.
    
    So, when the --containment flag is set, and a plugin is found:
    - do not change the scenerect anymore
    - do not resize the widget
    - do not wire up applet resize events to our view's scenerect
    - set window title to $Applet: $Containment
    - change icon to containment's icon
    
    This set of changes makes plasmoidviewer really useful, where it
    previously would often flick out of the view and show all kinds of
    applet placement madness when used with the --containment flag.


Diffs
-----

  plasmoidviewer/fullview.h eed247f 
  plasmoidviewer/fullview.cpp 109af6c 
  plasmoidviewer/main.cpp 1802982 

Diff: http://git.reviewboard.kde.org/r/108284/diff/


Testing
-------

tested with and without containments. Without --containment, behavior is unaffected initially and when resizing, with --containment, behavior matches expectations: i.e. the applet is under the containment's layout control.


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130109/3330b244/attachment.html>