Review Request: port kdelib's tooltip shadow code to icontasks, and remove halo

Xuetian Weng wengxt at gmail.com
Tue Jan 8 14:06:45 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108265/
-----------------------------------------------------------

Review request for Plasma, Cedric Bellegarde and Aaron J. Seigo.


Description
-------

copy dialogshadows to icontasks, and use DialogShadows to handle icon tasks shadow.

This is a different solution of https://git.reviewboard.kde.org/r/108241/ , I guess this is what it should be.

(remove halo part is just to keep consistency with default tooltip)


Diffs
-----

  applets/icontasks/CMakeLists.txt 1ff6042 
  applets/icontasks/tooltips/dialogshadows.cpp PRE-CREATION 
  applets/icontasks/tooltips/dialogshadows_p.h PRE-CREATION 
  applets/icontasks/tooltips/tooltip.cpp 43f09ed 
  applets/icontasks/tooltips/tooltipmanager.cpp dd36a9e 
  applets/icontasks/tooltips/windowpreview.cpp 94c9eb2 

Diff: http://git.reviewboard.kde.org/r/108265/diff/


Testing
-------

tested, no problem.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130108/bb78f94c/attachment.html>


More information about the Plasma-devel mailing list