Review Request: Do not clip away shadows in SlidingPopupsEffect

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108255/#review24977
-----------------------------------------------------------


Tested only with XRender so far:
Works fine, had a weird interaction with the Fade effect somehow, but it disappeared now (ie. the popup fading in, and fading out when they slide)
There is a little visual glitch with the shadow, the corner shadows overlap the side shadows for about one pixel. 
See http://privat.broulik.de/cornershadow.png

- Kai Uwe Broulik


On Jan. 8, 2013, 8:21 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108255/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2013, 8:21 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> Do not clip away shadows in SlidingPopupsEffect
> 
> Extracts the shadow areas from the window quads and adds them to the clip
> region, so that they are visible during the animation.
> 
> BUG: 312168
> FIXED-IN: 4.10
> 
> 
> This addresses bug 312168.
>     http://bugs.kde.org/show_bug.cgi?id=312168
> 
> 
> Diffs
> -----
> 
>   kwin/effects/slidingpopups/slidingpopups.h ff21eebad4c82a01b9a1345fdf76a88eea9df3d4 
>   kwin/effects/slidingpopups/slidingpopups.cpp 5ffc56b392a833127a6f22a60c2da10ae50f4c06 
> 
> Diff: http://git.reviewboard.kde.org/r/108255/diff/
> 
> 
> Testing
> -------
> 
> I did some testing, but I would appreciate if a few more people could try the patch and watch for rendering glitches. Sliding Popups has shown a huge regression potential in the past, so we have to be extremely careful if we want the patch in 4.10
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130108/2a7cff5b/attachment.html>