Review Request: use Plasma::Dialog for icontasks tooltips

[Cedric Bellegarde]

> On Jan. 7, 2013, 3 p.m., Xuetian Weng wrote:
> > applets/icontasks/tooltips/tooltip.cpp, line 267
> > <http://git.reviewboard.kde.org/r/108241/diff/1/?file=105524#file105524line267>
> >
> >     You'd better manually set
> >     
> >     setAttribute(Qt::WA_X11NetWmWindowTypeToolTip, true);
> >     
> >     Though Qt document said setWindowFlags(Qt::ToolTip) would set that, but as far as I test, seem it doesn't work (at least here, I don't know whether some other API affect it or not), and Plasma::Dialog use WA_X11NetWmWindowTypeToolTip to test whether to use edge hug with panel or not, you won't want that with tooltip.
> 
> Cedric Bellegarde wrote:
>     Sorry, but this should be fixed by icontasks dev, no ?

This code is code from Plasma::Tooltip.


- Cedric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108241/#review24918
-----------------------------------------------------------


On Jan. 7, 2013, 1:53 p.m., Cedric Bellegarde wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108241/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2013, 1:53 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Similiar to https://git.reviewboard.kde.org/r/108222, this would fix the shadow problem for icontasks tooltips
> 
> 
> Diffs
> -----
> 
>   applets/icontasks/tooltips/tooltip.cpp 43f09ed 
>   applets/icontasks/tooltips/tooltip_p.h 2b8ad0c 
> 
> Diff: http://git.reviewboard.kde.org/r/108241/diff/
> 
> 
> Testing
> -------
> 
> localily tested, no problem
> 
> 
> Thanks,
> 
> Cedric Bellegarde
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130108/e76c458f/attachment-0001.html>