Review Request: qml based kwin shadow

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108243/#review24920
-----------------------------------------------------------


Approach seems fine to me (though I haven't tested it yet). I'm wondering whether this could become part of Plasma Components?

In case not we should move it somewhere to make it part of the "KWin components" as we also need that in the KWin scripts (e.g. desktop change OSD).


kwin/tabbox/declarative.cpp
<http://git.reviewboard.kde.org/r/108243/#comment19116>

    nitpick: coding style
    } else {



kwin/tabbox/declarative.cpp
<http://git.reviewboard.kde.org/r/108243/#comment19117>

    all the variables are only set once, so maybe const them?



kwin/tabbox/declarative.cpp
<http://git.reviewboard.kde.org/r/108243/#comment19115>

    watch the whitespaces
    
    (in case you use any Kate-based editor: there's an option to only remove whitespaces on changed lines)


- Martin Gräßlin


On Jan. 7, 2013, 3:11 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108243/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2013, 3:11 p.m.)
> 
> 
> Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. Seigo, Marco Martin, and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> This is a different solution solve problem in https://git.reviewboard.kde.org/r/108224/
> 
> 1. use qml to draw shadow in DeclarativeView.
> 2. set blur mask svg property in qml
> 3. and fix some layout problem in big icons and small icons.
> 
> 
> Diffs
> -----
> 
>   kwin/tabbox/declarative.cpp 3bdcfac 
>   kwin/tabbox/qml/CMakeLists.txt d4bc863 
>   kwin/tabbox/qml/ShadowedSvgItem.qml PRE-CREATION 
>   kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml 7115b7f 
>   kwin/tabbox/qml/clients/compact/contents/ui/main.qml 1f6f036 
>   kwin/tabbox/qml/clients/informative/contents/ui/main.qml 3a2c4a3 
>   kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml 14a54d3 
>   kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml ea09ed0 
>   kwin/tabbox/qml/clients/text/contents/ui/main.qml c0def27 
>   kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml efe3ebe 
>   kwin/tabbox/qml/tabbox.qml 4176231 
> 
> Diff: http://git.reviewboard.kde.org/r/108243/diff/
> 
> 
> Testing
> -------
> 
> all desktop tabbox is tested with Air and Slim Glow, composite and non-composite, no problem.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130107/9649d43c/attachment.html>